[Templates] Proposed patch for truncate()
Clinton Gormley
clint@traveljury.com
Tue, 27 Mar 2007 01:34:52 +0200
> This code appears to be based on the String plugin rather than the
> truncate filter. Are you trying to change the filter instead or both
> maybe?
I didn't even know that Template::Plugin::String existed - a quick (and
erroneous grep)...
But it would make sense if both worked in the same way.
>
> Also, when posting patches (although this appears to be more of a
> demonstration than a patch) it'd be nice to see the diff -u on them
> rather than straight code so that it's easy to view what changes were
> made. (Be sure to post the version # you diff'd on as well.)
I will make changes to the filter as well, and post proper diffs for
both of them.
thanks
Clint
>
> The idea doesn't seem too crazy to me, especially since it wouldn't
> change existing behavior.
>
> -- Josh