[Templates] Anything outstanding for 2.15?
Josh Rosenbaum
josh@infogears.com
Mon, 15 May 2006 09:51:31 -0600
Here are two things I just found today:
I believe this documentation needs to be removed from the DBI.pm plugin/docs now, correct?
-------------------
IMPORTANT NOTE: the XS Stash (Template::Stash::XS) does not currently support access to tied hashes.....
-------------------
In Plugins/Table.pm (cvs line 220):
------------------------
if ($item =~ /^data|size|nrows|ncols|overlap|pad$/) {
My guess is that this should be:
if ($item =~ /^(?:data|size|nrows|ncols|overlap|pad)$/) {
------------------------
For previous "pending" patches I'd still like to see the check for backrefs when doing search and replace as noted in our previous thread. As I noted, that check is simple and results in a huge increase in speed when not using backrefs. I'm fine with foregoing the other "less readable" changes like removing subs, but I feel that this simple one is worth it.
http://template-toolkit.org/pipermail/templates/2006-February/008359.html
For the backref check only it looks like we would just add this between lines 85 and 86 in CVS:
-------------------------------------------------------
my $replace_has_backref;
while ($replace =~ m/(\\*) \$\d+/gx) {
if (length($1 || '') % 2 == 0) {
$replace_has_backref = 1;
last;
}
}
if (!$replace_has_backref) {
if ($global) {
$text =~ s/$pattern/$replace/g;
} else {
$text =~ s/$pattern/$replace/;
}
return $text;
}
-------------------------------------------------------
There was also a CHOMP patch being discussed I believe too.
Thread:
http://template-toolkit.org/pipermail/templates/2006-February/thread.html#8354
-- Josh
Andy Wardley wrote:
> Are there any outstanding patches or other updates for 2.15 that weren't
> in 2.14a?
>
> A
>
>
>
>
>
> _______________________________________________
> templates mailing list
> templates@template-toolkit.org
> http://lists.template-toolkit.org/mailman/listinfo/templates